Skip to content

tiny ar bug #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024
Merged

tiny ar bug #792

merged 1 commit into from
May 23, 2024

Conversation

jklugherz
Copy link
Contributor

No description provided.

@jklugherz jklugherz requested a review from a team as a code owner May 23, 2024 20:52
@jklugherz jklugherz requested a review from bpblanken May 23, 2024 20:52
@jklugherz jklugherz merged commit a41935a into dev May 23, 2024
3 checks passed
bpblanken added a commit that referenced this pull request May 28, 2024
* Miscellaneous VEP tweaks

* Benb/validate with allele type (#785)

* Bump requirements

* add validation

* format

* Fix syntax (#787)

* Bump requirements

* add validation

* format

* Fix syntax

* allele registry (#759)

* add allele registry step in update vat with samples task

* shh

* existing tests pass

* fix test deps

* test

* annotation_dependencies

* ruff

* take out the zero check

* fix requirements new task name

* move vep into new variants task

* only annotate lookup from callset_ht

* clean up mocks

* r

* working

* working?

* not that

* minor changes and test cases

* most recent script

* working version

* fix the test

* implement ht chunking

* fix patches

* fix patches

* register now yields id map of returned caids

* r

* fix some tests

* return a hail table instead

* use __str__

* log to track variants we can't map back

* move to gcs with flag

* union ar_ht instead of a bunch of left joins to prevent CAID, CAID_1, CAID_2...

* cleaner

* it is all coming together now
'

* gnomad ids for 37'

* use genomicalleles and gnomad ids

* secrets

* secret

* move stuff out of environment file

* add more logging

* fix test

* fix the other test

* ruff

* test

* comments

* o

* Reference Data Update Type Equality Check (#789)

* Finish validity check test

* ruff

* update dbnsfp field

* More types

* more types

* ugh

* twiddle it back

* update type

* more tweaks

* lint

* fix floats

* decompose

* ruff formatg

* Update compare_globals_test.py

* print lint rule (#791)

* tiny ar bug (#792)

---------

Co-authored-by: Benjamin Blankenmeister <bblanken@broadinstitute.org>
Co-authored-by: Benjamin Blankenmeister <b.p.blankenmeister@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants